Merge lp:~fwereade/juju-core/skip-openstack-ports into lp:~juju/juju-core/trunk

[William Reade]

environs/openstack: skip broken ports test

https://codereview.appspot.com/7335044/

[William Reade (fwereade)]

Reviewers: mp+148483_code.launchpad.net,

Message:
Please take a look.

Description:
environs/openstack: skip broken ports test

https://code.launchpad.net/~fwereade/juju-core/skip-openstack-ports/+merge/148483

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/7335044/

Affected files:
   A [revision details]
   M environs/openstack/local_test.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: environs/openstack/local_test.go
=== modified file 'environs/openstack/local_test.go'
--- environs/openstack/local_test.go 2013-02-08 16:11:57 +0000
+++ environs/openstack/local_test.go 2013-02-14 15:51:05 +0000
@@ -41,6 +41,10 @@
   Service *openstackservice.Openstack
  }

+func (s *localLiveSuite) TestPorts(c *C) {
+ c.Skip("not yet working")
+}
+
  func (s *localLiveSuite) SetUpSuite(c *C) {
   c.Logf("Using openstack service test doubles")

[William Reade (fwereade)]

Dropping this, apparently mgz has fixed it.

Unmerged revisions

893. By William Reade on 2013-02-14

skip broken test

892. By William Reade on 2013-02-14

state: fix validity checks in AuthEntity

R=rog
CC=
https://codereview.appspot.com/7312099

891. By Ian Booth on 2013-02-14

Get mongo from provider storage

Instead of hard coding the location of mongo to be an EC2 public bucket, allow mongo to be uploaded to the
specific provider's private or public storage. Use the EC2 location only as a fallback.

This change means that we can have an Openstack provider for which the tools and mongo can all be downloaded from the
same provider container, with no dependency on EC2, instead of the tools being somwhere and mongo somewhere else.

R=jameinel, dimitern
CC=
https://codereview.appspot.com/7307108

890. By Martin Packman on 2013-02-13

openstack: Basic ports support

Implement opening and closing of ports for the openstack provider using
security groups. This is pretty much copy-code from the existing ec2
version.

R=dimitern, jameinel
https://codereview.appspot.com/7314053/

889. By Roger Peppe on 2013-02-13

rpc: always use structs

Go 1.0.2 is more strict about json unmarshalling from nil,
so this patch makes the rpc package strict about requiring
structs for all parameters and results.

R=dimitern
CC=
https://codereview.appspot.com/7324048

888. By Roger Peppe on 2013-02-13

rpc: don't hang tests on failure

As suggested in previous CL.
Also delete Accept method, also suggested earlier
and not done.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/7324046

887. By John A Meinel on 2013-02-13

testing/charms: Remove the series parameter

This change removes some of the symlinks in the working tree (testing/repo/*).
Following on to it, there were a bunch of apis in testing.Charms that took a
series parameter, but all callers were just passing "series" anyway.

All the tests still pass, so I'm pretty happy with the changes.

R=dimitern, gz
CC=
https://codereview.appspot.com/7301073

886. By Gavin Panella on 2013-02-13

store, cmd/charm: Move them into lp:juju-store

Break out store and cmd/charm* into lp:juju-store

Red Squad are going to be working on the charm store, and it was
suggested that an early task would be to split the charm store out
into a separate project. That work has already been done - see
lp:juju-store - and this is the clean-up job.

mgz helped me a lot in doing both these tasks.

Fwiw, juju-store has not been advertised, so feel free to suggest a
different name.

R=fwereade
CC=
https://codereview.appspot.com/7058063/

885. By Roger Peppe on 2013-02-12

rpc: allow concurrent calls

The client side comes substantially from
the net/rpc package (no point in reinventing
the same wheel); the server side is a little
simpler, I hope.

R=fwereade
CC=
https://codereview.appspot.com/7307090

884. By Roger Peppe on 2013-02-12

state/api: enable password checking

R=TheMue, dimitern, fwereade
CC=
https://codereview.appspot.com/7299066

=== modified file 'environs/openstack/local_test.go'
--- environs/openstack/local_test.go	2013-02-08 16:11:57 +0000
+++ environs/openstack/local_test.go	2013-02-14 15:52:39 +0000
@@ -41,6 +41,10 @@
 	Service *openstackservice.Openstack
 }
 
+func (s *localLiveSuite) TestPorts(c *C) {
+	c.Skip("not yet working")
+}
+
 func (s *localLiveSuite) SetUpSuite(c *C) {
 	c.Logf("Using openstack service test doubles")