Code review comment for lp:~fwereade/juju-core/move-hook-context

Revision history for this message
William Reade (fwereade) wrote :

Reviewers: mp+127227_code.launchpad.net,

Message:
Please take a look.

Description:
server: move non-servery bits to hook

The only remaining bit of server is Server; the contexts and commands
have
moved to hook, and HookContext became plain Context, while other names
were
left as-is.

I am almost entirely certain that more steps will be required after this
before we hit on the right place/name/shape for everything, but I am
also
confident that this is a step in a good direction.

https://code.launchpad.net/~fwereade/juju-core/move-hook-context/+merge/127227

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/6596048/

Affected files:
   A [revision details]
   M cmd/jujuc/server/server_test.go
   M worker/uniter/hook/config-get.go
   M worker/uniter/hook/config-get_test.go
   M worker/uniter/hook/context.go
   M worker/uniter/hook/context_test.go
   M worker/uniter/hook/hook_test.go
   M worker/uniter/hook/juju-log.go
   M worker/uniter/hook/juju-log_test.go
   M worker/uniter/hook/ports.go
   M worker/uniter/hook/ports_test.go
   M worker/uniter/hook/relation-get.go
   M worker/uniter/hook/relation-get_test.go
   M worker/uniter/hook/relation-ids.go
   M worker/uniter/hook/relation-ids_test.go
   M worker/uniter/hook/relation-list.go
   M worker/uniter/hook/relation-list_test.go
   M worker/uniter/hook/relation-set.go
   M worker/uniter/hook/relation-set_test.go
   M worker/uniter/hook/unit-get.go
   M worker/uniter/hook/unit-get_test.go
   M worker/uniter/hook/util_test.go
   M worker/uniter/relationer.go
   M worker/uniter/tools.go
   M worker/uniter/tools_test.go
   M worker/uniter/uniter.go

« Back to merge proposal