Code review comment for lp:~fwereade/juju-core/manifest-charm-deployer

Revision history for this message
John A Meinel (jameinel) wrote :

I really enjoyed reviewing this, I wish you posted more code for us to
review. :)

Very well commented, and clearly robustly tested. LGTM

https://codereview.appspot.com/86910043/diff/1/worker/uniter/charm/converter_test.go
File worker/uniter/charm/converter_test.go (right):

https://codereview.appspot.com/86910043/diff/1/worker/uniter/charm/converter_test.go#newcode128
worker/uniter/charm/converter_test.go:128: ft.File{"common", "final",
0644}.Check(c, s.targetPath)
You don't seem to check what the status of "user" is here.

https://codereview.appspot.com/86910043/

« Back to merge proposal