Code review comment for lp:~fwereade/juju-core/config-7-deploy-sensible-layering

Reviewers: mp+168581_code.launchpad.net,

Message:
Please take a look.

Description:
deploy refactoring

GUI deploy and CLI deploy are different enough that the common statecmd
caused more problems than it solved. Testing is noticeably improved.

juju.Conn.DeployService and juju.Conn.AddUnits are now probably ready to
move to some other place that just requires a state connection (and not
an environment as well); juju.Conn.PutCharm needs some love too, and
thought devoted to how we're going to put local charms over the API.

But, for now, the various bits all happen in the right place (*except*
that
the CLI once again downloads store charms and uploads them itself,
rather
than taking advantage of that functionality on the server side. This can
and will be fixed, but not this CL).

https://code.launchpad.net/~fwereade/juju-core/config-7-deploy-sensible-layering/+merge/168581

Requires:
https://code.launchpad.net/~fwereade/juju-core/config-6-state-service-sane-methods/+merge/168580

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/10166044/

Affected files:
   A [revision details]
   M cmd/juju/deploy.go
   M cmd/juju/deploy_test.go
   M juju/conn.go
   M juju/conn_test.go
   M state/api/params/params.go
   M state/apiserver/client.go
   M state/apiserver/client_test.go
   M state/apiserver/perm_test.go
   D state/statecmd/deploy.go
   D state/statecmd/deploy_test.go
   M testing/charm.go