Code review comment for lp:~fwereade/juju-core/config-6-state-service-sane-methods

Revision history for this message
William Reade (fwereade) wrote :

Reviewers: mp+168580_code.launchpad.net,

Message:
Please take a look.

Description:
state: Service ConfigSettings methods

Config, SetConfig, and SetConfigYAML methods have been dropped in favour
of
ConfigSettings and UpdateConfigSettings, which use sensible types.
Clients
are expected to parse their own damn data and supply a sensible format.

https://code.launchpad.net/~fwereade/juju-core/config-6-state-service-sane-methods/+merge/168580

Requires:
https://code.launchpad.net/~fwereade/juju-core/config-5-state-service-config-yaml/+merge/168579

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/10083047/

Affected files:
   A [revision details]
   M cmd/juju/cmd_test.go
   M cmd/juju/config_test.go
   M cmd/juju/deploy.go
   M cmd/juju/deploy_test.go
   M cmd/juju/set.go
   M juju/conn.go
   M juju/conn_test.go
   M state/api/client.go
   M state/api/params/params_test.go
   M state/apiserver/client.go
   M state/apiserver/client_test.go
   M state/megawatcher_internal_test.go
   M state/service.go
   M state/service_test.go
   M state/statecmd/config_test.go
   M state/statecmd/deploy_test.go
   M state/statecmd/get.go
   M state/unit_test.go
   M worker/uniter/context_test.go
   M worker/uniter/filter_test.go
   M worker/uniter/uniter_test.go

« Back to merge proposal