Code review comment for lp:~fwereade/juju-core/config-2-trivial-error-message-change

Revision history for this message
Roger Peppe (rogpeppe) wrote :

looks reasonable, but what's the deal with the new errors package?

https://codereview.appspot.com/10178043/diff/1/charm/repo.go
File charm/repo.go (right):

https://codereview.appspot.com/10178043/diff/1/charm/repo.go#newcode295
charm/repo.go:295: return &NotFoundError{fmt.Sprintf("charm not found in
%q: %s", repoPath, curl)}
shouldn't this be using errors.NotFoundf ?

https://codereview.appspot.com/10178043/

« Back to merge proposal