https://codereview.appspot.com/7610048/diff/1/environs/bootstrap_test.go#newcode39
environs/bootstrap_test.go:39: err := environs.Bootstrap(env,
state.Constraints{}, false, nil)
+1, as it also means the struct doesn't get copied when it doesn't need
to. Though I suppose we want to avoid the side-effect of passing in
constraints and then changing the in-memory struct later?
But that could just be the final e.constraints = *cons (so it does do an
explicit copy at that point).
LGTM
https:/ /codereview. appspot. com/7610048/ diff/1/ environs/ bootstrap_ test.go bootstrap_ test.go (right):
File environs/
https:/ /codereview. appspot. com/7610048/ diff/1/ environs/ bootstrap_ test.go# newcode39 bootstrap_ test.go: 39: err := environs. Bootstrap( env, ts{}, false, nil)
environs/
state.Constrain
+1, as it also means the struct doesn't get copied when it doesn't need
to. Though I suppose we want to avoid the side-effect of passing in
constraints and then changing the in-memory struct later?
But that could just be the final e.constraints = *cons (so it does do an
explicit copy at that point).
https:/ /codereview. appspot. com/7610048/