Code review comment for lp:~futatuki/mailman/enhance-i18n-list-overview

Revision history for this message
Mark Sapiro (msapiro) wrote :

In your change to Mailman/Cgi/admin.py, mlist.GetDescription() should be Utils.websafe(mlist.GetDescription()). I know it isn't currently websafed, but it should be.

I understand the need for the changes to admin.py and listinfo.py because the overview page is in the charset of the site's preferred language and the description may not be.

There is also another issue in the listinfo for a specific list. Here the <mm-list-description> replacement puts the description at the top of the page and the page can be viewed in a language other than the list default, so I think Mailman/HTMLFormatter.py needs to also be changed to use GetDescription() for the <mm-list-description> replacement.

Finally though, I don't understand the need for the change to Mailman/Gui/GUIBase.py since there we are dealing with changes via the admin CGI for a list and the admin UI should be in the list's preferred language charset always. Am I missing something here?

review: Needs Information (code)

« Back to merge proposal