Merge lp:~fu-wei/lava-dispatcher/multinode into lp:lava-dispatcher/multinode

Proposed by Fu Wei
Status: Merged
Approved by: Neil Williams
Approved revision: no longer in the source branch.
Merged at revision: 670
Proposed branch: lp:~fu-wei/lava-dispatcher/multinode
Merge into: lp:lava-dispatcher/multinode
Diff against target: 24 lines (+10/-3)
1 file modified
lava_dispatcher/signals/__init__.py (+10/-3)
To merge this branch: bzr merge lp:~fu-wei/lava-dispatcher/multinode
Reviewer Review Type Date Requested Status
Neil Williams Pending
Review via email: mp+177870@code.launchpad.net

Description of the change

fix lava-sync bug for message delivery

To post a comment you must log in.
lp:~fu-wei/lava-dispatcher/multinode updated
670. By Neil Williams

Fu Wei 2013-07-31 fix lava-sync bug for message delivery

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lava_dispatcher/signals/__init__.py'
--- lava_dispatcher/signals/__init__.py 2013-07-31 11:59:10 +0000
+++ lava_dispatcher/signals/__init__.py 2013-07-31 15:06:08 +0000
@@ -209,10 +209,17 @@
209 msg = {"request": "lava_sync", "messageID": message_id, "message": None}209 msg = {"request": "lava_sync", "messageID": message_id, "message": None}
210 reply = self.context.transport(json.dumps(msg))210 reply = self.context.transport(json.dumps(msg))
211 logging.debug("Node transport replied with %s" % reply)211 logging.debug("Node transport replied with %s" % reply)
212 ret = self.connection.sendline("<LAVA_SYNC_COMPLETE %s>" % json.dumps(reply))212 message_str = ""
213 if reply == "nack":
214 raise FailedCall("LAVA_SYNC nack")
215 message_str = " nack"
216# elif reply == "TIMEOUT":
217# raise FailedCall("LAVA_SYNC TIMEOUT")
218# message_str = " TIMEOUT"
219 else:
220 message_str = ""
221 ret = self.connection.sendline("<LAVA_SYNC_COMPLETE%s>" % message_str)
213 logging.debug("runner._connection.sendline wrote %d bytes" % ret)222 logging.debug("runner._connection.sendline wrote %d bytes" % ret)
214 if reply == "nack":
215 raise FailedCall("LAVA_SYNC nack")
216223
217 def _on_WAIT(self, message_id):224 def _on_WAIT(self, message_id):
218 if not self.connection:225 if not self.connection:

Subscribers

People subscribed via source and target branches

to status/vote changes: