Juju Charms Collection
percona-cluster package

Code review comment for lp:~freyes/charms/trusty/percona-cluster/lp1426508

  1. Trusty Tahr (14.04)
  2. lp1426508
  3. Merge into next
Revision history for this message
Felipe Reyes (freyes) wrote :

On Mon, 13 Apr 2015 09:59:31 -0000
James Page <email address hidden> wrote:

> Thinking about 'local.yaml' - that's a bit tricky for our automated
> testing tooling - however using a environment variable is not - (I
> see 'VIP' in the code already).
Yeah, it is, I wasn't proud about it.

> Please could you scope that to be AMULET_OS_VIP and pass it through
> in the Makefile:
>
> @juju test -v -p AMULET_HTTP_PROXY,AMULET_OS_VIP --timeout 900
Good idea, I'll use that approach. I didn't know about what really did
'-p'.

« Back to merge proposal