Code review comment for lp:~freyes/charms/trusty/percona-cluster/lp1426508

Revision history for this message
James Page (james-page) wrote :

Felipe

This looks like a really good start to resolving this challenge; generally you changes look fine (a few inline comments) but I really would like to see upgrades for existing deployments handled as well.

This would involve re-executing the ha_relation_joined function from the upgrade-charm/config-changed hook so that corosync can reconfigure its resources as required.

review: Needs Fixing

« Back to merge proposal