Code review comment for lp:~freyes/charms/trusty/nova-cloud-controller/single-nova-consoleauth

Revision history for this message
Edward Hope-Morley (hopem) wrote :

So i should have noticed before but, your code is living in config_changed() but relies on the ha relation to exist so it will never get called unless the ha relation exists prior to config_changed() being run...which will not be the case unless you modify charm config after the hacluster has completed installation and relations have been added. So, i suggest you move that code into the ha_joined() or ha_changed() hooks and call it from config_changed() assuming that is safe to do.

review: Needs Fixing

« Back to merge proposal