Juju Charms Collection
nova-cloud-controller package

Code review comment for lp:~freyes/charms/trusty/nova-cloud-controller/bug-989337

  1. Trusty Tahr (14.04)
  2. bug-989337
  3. Merge into next
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Felipe, thanks for working on this it is much needed.

So some initial comments;

  * could you please rename the cache-relation-* to memcache-relation-*
  * is there are reason for replacing config() with hookenv.config()? I know it is not the nicest coding style but it is the same across all charms so to do it differently here would be breaking convention.
  * some more comments inline

review: Needs Fixing

« Back to merge proposal