Code review comment for lp:~freyes/charms/trusty/memcached/lp1525026

Revision history for this message
Adam Israel (aisrael) wrote :

I ran fresh tests on LXC and Amazon yesterday, and both failed.

I think I fixed the tests on LXC (it works locally for me now), by setting allow-ufw-ip6-softfail = True and removing what looked like a duplicate line calling d.sentry['memcached/0']

https://code.launchpad.net/~aisrael/charms/trusty/memcached/charm-review-fixes

Tests are still failing on Amazon, unfortunately. Here's the bundletester output; I added some extra output in the failure to illustrate what's happening:

http://pastebin.ubuntu.com/14688975/

It looks like it's comparing a private against a public address.

Please let me know if you need any other information or you'd like me to retest.

review: Needs Fixing

« Back to merge proposal