Code review comment for lp:~free.ekanayaka/landscape-client/socket-locks-fix

Revision history for this message
Gavin Panella (allenap) wrote :

Cool, +1 :)

[2]

Thanks for the explanation, and I agree they should be left alone for now.

> self.addCleanup(lambda: setattr(reactor._reactor, "stop", saved_stop))

Not that it matters a lot, but I think this can be simplified to:

  self.addCleanup(setattr, reactor._reactor, "stop", saved_stop)

review: Approve

« Back to merge proposal