Code review comment for lp:~free.ekanayaka/landscape-client/amp-cleanup-9

Revision history for this message
Chris Glass (tribaal) wrote :

Great branch! Thanks a lot for all this refactoring, the code is much, much cleaner and easier to read now. +1
Man, inline callbacks + yield is so much nicer :)

[1]
While not directly related to your branch, could you please rename the "object" variable to "obj" or something in MethodCallReceiver's __init__()? It's not hugely important in this particular case, but overriding builtins even for a limited scope is a bit ugly :)

[2]
Same comment in MethodCallServerProtocol.

[3]
Same comment in MethodCallServerFactory's __init__

review: Approve

« Back to merge proposal