Merge ~freddie-akeroyd/epics-base:appveyor_debug_builds into ~epics-core/epics-base/+git/epics-base:7.0

[Freddie Akeroyd]

Enable VS 2019 and debug builds on Appveyor

* Add VS2019 build target
* Install Strawberry perl when building VS2019 (this image is missing perl)
* Build debug configuration with MSVC (previously just mingw and cygwin)
* allow static-debug on MSVC by setting -static and modifying CONFIG_SITE

LP: #1845887

[Andrew Johnson (anj)]

Group 10/4: Looks reasonable.

review: Approve

[mdavidsaver (mdavidsaver)]

FYI, this MR will not be included in the forthcoming 7.0.3.1 release. Not due to any issue with the appveyor config changes, but rather to the runtime issues (hang or crash on exit) it seemingly uncovers with the unittest suite and MSVC 2019.

[Andrew Johnson (anj)]

This branch now has merge conflicts with the latest appveyor CI files.

@Ralph, when you get a chance can you take a look at this and work out what needs doing?

review: Needs Fixing

43a0eb8... by Freddie Akeroyd on 2019-12-19

Merge remote-tracking branch 'upstream' into appveyor_debug_builds

[Freddie Akeroyd (freddie-akeroyd)]

I have resolved the merge conflict, most of the changes on this branch seem to have already been included upstream and the only item remaining here is to cache downloads of external tools.

[Andrew Johnson (anj)]

Gropu review 2020-03-25: Approve.

review: Approve

[Andrew Johnson (anj)]

@Ralph can you take a look at this MR and see if it should still be applied. It has been sitting in this Approved state since March but we haven't actually merged it yet (Sorry Freddie!).

[Andrew Johnson (anj)]

This merge request is no longer relevant to epics-base, the functionality of the script it's modifying has been taken over by Python code in the ci-scripts module.

review: Disapprove

Unmerged commits

43a0eb8... by Freddie Akeroyd on 2019-12-19

Merge remote-tracking branch 'upstream' into appveyor_debug_builds

d855d3a... by Freddie Akeroyd on 2019-10-03

Add build cache

diff --git a/.appveyor.yml b/.appveyor.yml
index bba0292..9e867fa 100644
--- a/.appveyor.yml
+++ b/.appveyor.yml
@@ -6,6 +6,9 @@
 # Version format
 version: base-{branch}-{build}
 
+cache:
+- C:\Downloads -> .ci\appveyor-prepare.bat
+
 #---------------------------------#
 #       repository cloning        #
 #---------------------------------#
diff --git a/.ci/appveyor-prepare.bat b/.ci/appveyor-prepare.bat
index 312223d..63b67ff 100644
--- a/.ci/appveyor-prepare.bat
+++ b/.ci/appveyor-prepare.bat
@@ -35,17 +35,28 @@ echo.%CONFIGURATION% | findstr /C:"debug">nul && (
     echo [INFO] EPICS set up for optimized build
 )
 
-echo [INFO] Installing Make 4.2.1 from ANL web site
-curl -fsS --retry 3 -o C:\tools\make-4.2.1.zip https://epics.anl.gov/download/tools/make-4.2.1-win64.zip
+:: C:\Downloads is listed as an appveyor chache directory in .appveyor.yml
+if not exist "C:\Downloads" (
+    mkdir C:\Downloads
+)
+if not exist "C:\Downloads\make-4.2.1.zip" (
+    echo [INFO] Downloading Make 4.2.1 from ANL web site
+    curl -fsS --retry 3 -o C:\Downloads\make-4.2.1.zip https://epics.anl.gov/download/tools/make-4.2.1-win64.zip
+)
+set "PERLVER=5.30.0.1"
+if not exist "C:\Downloads\perl-%PERLVER%.zip" (
+    echo [INFO] Downloading Strawberry Perl %PERLVER%
+    curl -fsS --retry 3 -o C:\Downloads\perl-%PERLVER%.zip http://strawberryperl.com/download/%PERLVER%/strawberry-perl-%PERLVER%-64bit.zip
+)
+
+echo [INFO] Installing Make 4.2.1
 cd \tools
-"C:\Program Files\7-Zip\7z" e make-4.2.1.zip
+"C:\Program Files\7-Zip\7z" e c:\Downloads\make-4.2.1.zip
 
-set "PERLVER=5.30.0.1"
 if "%TOOLCHAIN%"=="2019" (
     echo [INFO] Installing Strawberry Perl %PERLVER%
-    curl -fsS --retry 3 -o C:\tools\perl-%PERLVER%.zip http://strawberryperl.com/download/%PERLVER%/strawberry-perl-%PERLVER%-64bit.zip
     cd \tools
-    "C:\Program Files\7-Zip\7z" x perl-%PERLVER%.zip -oC:\strawberry
+    "C:\Program Files\7-Zip\7z" x C:\Downloads\perl-%PERLVER%.zip -oC:\strawberry
     cd \strawberry
     :: we set PATH in appveyor-build.bat
     call relocation.pl.bat