Code review comment for lp:~frankban/python-fixtures/fakelogger-getdetails

Revision history for this message
Jonathan Lange (jml) wrote :

testtools.content.content_from_stream might be slightly better than Content(UTF8_TEXT, ...) for verbose logs, as it reads the content in chunks. If not t.c.text_content does almost the same thing as the current code and is briefer.

It's not clear to me *when* you want to do the read. Presumably it's when getDetails is called, which seems to be what the current version does (and what content_from_stream would do). I don't really understand Robert's last paragraph.

« Back to merge proposal