Code review comment for lp:~frankban/lpsetup/bug-1034602-handle-target-dir

The attempt to merge lp:~frankban/lpsetup/bug-1034602-handle-target-dir into lp:lpsetup failed. Below is the output from the failed tests.

+ set -o errexit
++ grep -v distribute_setup.py
++ find . -name build -prune -o -name '*.py'
+ pyfiles='./setup.py
./lplxcip/tests/utils.py
./lplxcip/tests/__init__.py
./lplxcip/tests/test_lxcip.py
./lplxcip/tests/test_helpers.py
./lplxcip/tests/test_utils.py
./lplxcip/lxcip.py
./lpsetup/utils.py
./lpsetup/__init__.py
./lpsetup/handlers.py
./lpsetup/tests/utils.py
./lpsetup/tests/__init__.py
./lpsetup/tests/test_argparser.py
./lpsetup/tests/test_cli.py
./lpsetup/tests/test_handlers.py
./lpsetup/tests/subcommands/__init__.py
./lpsetup/tests/subcommands/test_version.py
./lpsetup/tests/subcommands/test_initrepo.py
./lpsetup/tests/subcommands/test_init_target.py
./lpsetup/tests/subcommands/test_smoke.py
./lpsetup/tests/integration/common.py
./lpsetup/tests/integration/test_install_lxc.py
./lpsetup/tests/integration/test_init_target.py
./lpsetup/tests/test_utils.py
./lpsetup/subcommands/__init__.py
./lpsetup/subcommands/install_lxc.py
./lpsetup/subcommands/initlxc.py
./lpsetup/subcommands/init_target.py
./lpsetup/subcommands/update.py
./lpsetup/subcommands/initrepo.py
./lpsetup/subcommands/version.py
./lpsetup/exceptions.py
./lpsetup/argparser.py
./lpsetup/settings.py
./lpsetup/cli.py'
+ pocketlint ./setup.py ./lplxcip/tests/utils.py ./lplxcip/tests/__init__.py ./lplxcip/tests/test_lxcip.py ./lplxcip/tests/test_helpers.py ./lplxcip/tests/test_utils.py ./lplxcip/lxcip.py ./lpsetup/utils.py ./lpsetup/__init__.py ./lpsetup/handlers.py ./lpsetup/tests/utils.py ./lpsetup/tests/__init__.py ./lpsetup/tests/test_argparser.py ./lpsetup/tests/test_cli.py ./lpsetup/tests/test_handlers.py ./lpsetup/tests/subcommands/__init__.py ./lpsetup/tests/subcommands/test_version.py ./lpsetup/tests/subcommands/test_initrepo.py ./lpsetup/tests/subcommands/test_init_target.py ./lpsetup/tests/subcommands/test_smoke.py ./lpsetup/tests/integration/common.py ./lpsetup/tests/integration/test_install_lxc.py ./lpsetup/tests/integration/test_init_target.py ./lpsetup/tests/test_utils.py ./lpsetup/subcommands/__init__.py ./lpsetup/subcommands/install_lxc.py ./lpsetup/subcommands/initlxc.py ./lpsetup/subcommands/init_target.py ./lpsetup/subcommands/update.py ./lpsetup/subcommands/initrepo.py ./lpsetup/subcommands/version.py ./lpsetup/exceptions.py ./lpsetup/argparser.py ./lpsetup/settings.py ./lpsetup/cli.py
+ pep8 --exclude=build ./setup.py ./lplxcip/tests/utils.py ./lplxcip/tests/__init__.py ./lplxcip/tests/test_lxcip.py ./lplxcip/tests/test_helpers.py ./lplxcip/tests/test_utils.py ./lplxcip/lxcip.py ./lpsetup/utils.py ./lpsetup/__init__.py ./lpsetup/handlers.py ./lpsetup/tests/utils.py ./lpsetup/tests/__init__.py ./lpsetup/tests/test_argparser.py ./lpsetup/tests/test_cli.py ./lpsetup/tests/test_handlers.py ./lpsetup/tests/subcommands/__init__.py ./lpsetup/tests/subcommands/test_version.py ./lpsetup/tests/subcommands/test_initrepo.py ./lpsetup/tests/subcommands/test_init_target.py ./lpsetup/tests/subcommands/test_smoke.py ./lpsetup/tests/integration/common.py ./lpsetup/tests/integration/test_install_lxc.py ./lpsetup/tests/integration/test_init_target.py ./lpsetup/tests/test_utils.py ./lpsetup/subcommands/__init__.py ./lpsetup/subcommands/install_lxc.py ./lpsetup/subcommands/initlxc.py ./lpsetup/subcommands/init_target.py ./lpsetup/subcommands/update.py ./lpsetup/subcommands/initrepo.py ./lpsetup/subcommands/version.py ./lpsetup/exceptions.py ./lpsetup/argparser.py ./lpsetup/settings.py ./lpsetup/cli.py
+ nosetests
........................................................................................................................E.E.............................................
======================================================================
ERROR: test_absolute_path (lpsetup.tests.test_handlers.HandleTargetDirTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tarmac/repos/lpsetup/trunk/lpsetup/tests/test_handlers.py", line 294, in test_absolute_path
    handle_target_dir(namespace)
  File "/home/tarmac/repos/lpsetup/trunk/lpsetup/handlers.py", line 285, in handle_target_dir
    target_dir))
ValidationError: the target dir /tmp/tmpHyCGig does not exist or is not a directory.

======================================================================
ERROR: test_expanduser (lpsetup.tests.test_handlers.HandleTargetDirTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tarmac/repos/lpsetup/trunk/lpsetup/tests/test_handlers.py", line 301, in test_expanduser
    handle_target_dir(namespace)
  File "/home/tarmac/repos/lpsetup/trunk/lpsetup/handlers.py", line 285, in handle_target_dir
    target_dir))
ValidationError: the target dir /tmp/tmpEnzWL8 does not exist or is not a directory.

Name Stmts Miss Cover Missing
---------------------------------------------------------------
lpsetup 6 0 100%
lpsetup.argparser 123 2 98% 226, 255
lpsetup.cli 79 8 90% 65-66, 83-85, 121-122, 179
lpsetup.exceptions 6 0 100%
lpsetup.handlers 96 1 99% 244
lpsetup.settings 33 0 100%
lpsetup.subcommands 0 0 100%
lpsetup.subcommands.init_target 132 50 62% 101, 138-142, 152-177, 198-205, 222-240, 246, 251-259, 268-272
lpsetup.subcommands.initlxc 91 44 52% 63-67, 82-126, 139, 146-147, 160-205, 214-217, 224-226
lpsetup.subcommands.initrepo 73 10 86% 64-66, 73, 78-80, 87-89
lpsetup.subcommands.install_lxc 66 34 48% 44-46, 55-81, 91-92, 98-107, 117-121, 131-140
lpsetup.subcommands.update 49 18 63% 34-35, 44-63, 74-75, 86-88
lpsetup.subcommands.version 11 0 100%
lpsetup.utils 190 41 78% 122, 189, 243-253, 268, 307-314, 336, 346, 362-370, 387-393, 408-410, 422-428
---------------------------------------------------------------
TOTAL 955 208 78%
----------------------------------------------------------------------
Ran 168 tests in 14.739s

FAILED (errors=2)