Code review comment for lp:~frankban/launchpad/lpsetup-initial

Revision history for this message
Francesco Banconi (frankban) wrote :

> - this might be a lot better off in the lp-dev-tools project, its
> clearly not part of LP itself. That would also make it easier to split
> it into N files as you would not be stuck in the bootstrap stage of
> the users environment (we could package that and mandate the package
> be installed).

I agree. Indeed we were thinking about creating an lpsetup project.
In general I think it's a good idea to have this separated from
launchpad itself and splitted into N files.

> - the environ context manager is duplicative of the
> EnvironmentVariable fixture; it would be nice not to rewrite code that
> has already been written and tested (and is used in our environment
> too!) Yes, I know that this is small, but it does all add up, and
> someone somewhere will eventually be cursing that they have to redo
> this / fix a unicode escaping issue in the code or whatever.

Thanks for the hint. I will take a look at python-fixtures and testr integrated subcommands framework.
Once this no longer is a single file, it will be easy to add dependencies.

Thanks again Robert.

« Back to merge proposal