LGTM. No QA yet.
https://codereview.appspot.com/194030043/diff/1/quickstart/cli/views.py File quickstart/cli/views.py (right):
https://codereview.appspot.com/194030043/diff/1/quickstart/cli/views.py#newcode314 quickstart/cli/views.py:314: # and supposed to be working/active. The user has the ability to select Maybe 'assumed' would be clearer than 'supposed'?
https://codereview.appspot.com/194030043/diff/1/quickstart/tests/cli/test_params.py File quickstart/tests/cli/test_params.py (right):
https://codereview.appspot.com/194030043/diff/1/quickstart/tests/cli/test_params.py#newcode87 quickstart/tests/cli/test_params.py:87: self.assertNotEqual(self.params, params) Such a nice set of tests! Thanks for the clarity.
https://codereview.appspot.com/194030043/
« Back to merge proposal
LGTM. No QA yet.
https:/ /codereview. appspot. com/194030043/ diff/1/ quickstart/ cli/views. py cli/views. py (right):
File quickstart/
https:/ /codereview. appspot. com/194030043/ diff/1/ quickstart/ cli/views. py#newcode314 cli/views. py:314: # and supposed to be working/active. The
quickstart/
user has the ability to select
Maybe 'assumed' would be clearer than 'supposed'?
https:/ /codereview. appspot. com/194030043/ diff/1/ quickstart/ tests/cli/ test_params. py tests/cli/ test_params. py (right):
File quickstart/
https:/ /codereview. appspot. com/194030043/ diff/1/ quickstart/ tests/cli/ test_params. py#newcode87 tests/cli/ test_params. py:87: self.assertNotE qual(self. params,
quickstart/
params)
Such a nice set of tests! Thanks for the clarity.
https:/ /codereview. appspot. com/194030043/