LGTM Thanks for getting this working! I'll QA once we chat about my comment.
https://codereview.appspot.com/197240043/diff/20001/quickstart/tests/functional/test_functional.py File quickstart/tests/functional/test_functional.py (right):
https://codereview.appspot.com/197240043/diff/20001/quickstart/tests/functional/test_functional.py#newcode46 quickstart/tests/functional/test_functional.py:46: env_name = envs.get_default_env_name() As a precautionary measure I would prefer if there was a default environment name for these tests. That way there would be no possible way someone would accidentally run these tests on a live environment.
https://codereview.appspot.com/197240043/
« Back to merge proposal
LGTM Thanks for getting this working! I'll QA once we chat about my
comment.
https:/ /codereview. appspot. com/197240043/ diff/20001/ quickstart/ tests/functiona l/test_ functional. py tests/functiona l/test_ functional. py (right):
File quickstart/
https:/ /codereview. appspot. com/197240043/ diff/20001/ quickstart/ tests/functiona l/test_ functional. py#newcode46 tests/functiona l/test_ functional. py:46: env_name = default_ env_name( )
quickstart/
envs.get_
As a precautionary measure I would prefer if there was a default
environment name for these tests. That way there would be no possible
way someone would accidentally run these tests on a live environment.
https:/ /codereview. appspot. com/197240043/