Code review comment for lp:~frankban/juju-quickstart/support-old-series

Revision history for this message
Brad Crittenden (bac) wrote :

LGTM. No QA.

https://codereview.appspot.com/197240043/diff/1/quickstart/tests/functional/test_functional.py
File quickstart/tests/functional/test_functional.py (right):

https://codereview.appspot.com/197240043/diff/1/quickstart/tests/functional/test_functional.py#newcode87
quickstart/tests/functional/test_functional.py:87: cls.retcode,
cls.output, cls.error = run_quickstart(cls.env_name)
Thanks for the thoughtful test implementation.

It may be worth noting that run_quickstart only happens once per suite
not once per test as it isn't super obvious since we don't use
setUpClass all that much.

https://codereview.appspot.com/197240043/

« Back to merge proposal