Code review comment for lp:~frankban/juju-quickstart/remove-jenv

Revision history for this message
Francesco Banconi (frankban) wrote :

Please take a look.

https://codereview.appspot.com/189540043/diff/1/quickstart/cli/params.py
File quickstart/cli/params.py (right):

https://codereview.appspot.com/189540043/diff/1/quickstart/cli/params.py#newcode37
quickstart/cli/params.py:37: )
On 2015/01/12 15:29:32, bac wrote:
> Formatting is odd. I'd prefer one per line if you're doing
multi-line.

Done.

https://codereview.appspot.com/189540043/diff/1/quickstart/cli/views.py
File quickstart/cli/views.py (right):

https://codereview.appspot.com/189540043/diff/1/quickstart/cli/views.py#newcode528
quickstart/cli/views.py:528: '\nFor this reason, it is not possible to
edit/change it.\n'
On 2015/01/12 14:50:22, martin.hilton wrote:
> Isn't edit/change a tautology? Wouldn't "edit it." be enough.

Done.

https://codereview.appspot.com/189540043/

« Back to merge proposal