Code review comment for lp:~frankban/juju-quickstart/quickstart-watch

On 2013/10/18 13:45:07, gary.poster wrote:
> make check: good. The obsessive compulsive in me wants to see
coverage for the
> run function, so we get 100% ;-)

> I had some issues in QA but they seemed Juju-related, not quickstart
related,
> and as you suggested, my system has an old Juju. I will update and
try again.

> During the qa, though, the text did confuse me.

> ---
> connecting to wss://ec2-50-17-120-194.compute-1.amazonaws.com:17070
> deploying Juju GUI
> service deployed and exposed
> juju-gui/0 deployment is pending
> ---

> What would you think of changing the second and third lines to
something like
> these?

> ---
> connecting to wss://ec2-50-17-120-194.compute-1.amazonaws.com:17070
> requesting Juju GUI deployment
> Juju GUI deployment request accepted
> juju-gui/0 deployment is pending
> ---

> Better ideas welcome, but I think it is weird to see "deployed and
exposed" but
> then "deployment is pending".

Done, thanks for the review Gary!

https://codereview.appspot.com/15020043/