Code review comment for lp:~frankban/juju-quickstart/quickstart-watch

Revision history for this message
Gary Poster (gary) wrote :

code LGTM with small comment about comment. Trying qa now.

https://codereview.appspot.com/15020043/diff/1/quickstart/app.py
File quickstart/app.py (right):

https://codereview.appspot.com/15020043/diff/1/quickstart/app.py#newcode127
quickstart/app.py:127: def watch(env, service_name):
Nicely readable.

https://codereview.appspot.com/15020043/diff/1/quickstart/manage.py
File quickstart/manage.py (right):

https://codereview.appspot.com/15020043/diff/1/quickstart/manage.py#newcode153
quickstart/manage.py:153: # there is no attached terminal.
I think the looking for an attached terminal is only important if we are
trying to ask the user for input. I originally thought we would ask the
user if he/she wanted us to open the browser, but in retrospect I think
simply defaulting to opening the browser, and having a flag to disable
this behavior, is sufficient. And fast. :-)

https://codereview.appspot.com/15020043/diff/1/quickstart/tests/test_app.py
File quickstart/tests/test_app.py (right):

https://codereview.appspot.com/15020043/diff/1/quickstart/tests/test_app.py#newcode310
quickstart/tests/test_app.py:310: # The glorious moments in the unit's
life are properly highlighted.
LOL

https://codereview.appspot.com/15020043/

« Back to merge proposal