https://codereview.appspot.com/15020043/diff/1/quickstart/manage.py#newcode153
quickstart/manage.py:153: # there is no attached terminal.
I think the looking for an attached terminal is only important if we are
trying to ask the user for input. I originally thought we would ask the
user if he/she wanted us to open the browser, but in retrospect I think
simply defaulting to opening the browser, and having a flag to disable
this behavior, is sufficient. And fast. :-)
code LGTM with small comment about comment. Trying qa now.
https:/ /codereview. appspot. com/15020043/ diff/1/ quickstart/ app.py
File quickstart/app.py (right):
https:/ /codereview. appspot. com/15020043/ diff/1/ quickstart/ app.py# newcode127 app.py: 127: def watch(env, service_name):
quickstart/
Nicely readable.
https:/ /codereview. appspot. com/15020043/ diff/1/ quickstart/ manage. py manage. py (right):
File quickstart/
https:/ /codereview. appspot. com/15020043/ diff/1/ quickstart/ manage. py#newcode153 manage. py:153: # there is no attached terminal.
quickstart/
I think the looking for an attached terminal is only important if we are
trying to ask the user for input. I originally thought we would ask the
user if he/she wanted us to open the browser, but in retrospect I think
simply defaulting to opening the browser, and having a flag to disable
this behavior, is sufficient. And fast. :-)
https:/ /codereview. appspot. com/15020043/ diff/1/ quickstart/ tests/test_ app.py tests/test_ app.py (right):
File quickstart/
https:/ /codereview. appspot. com/15020043/ diff/1/ quickstart/ tests/test_ app.py# newcode310 tests/test_ app.py: 310: # The glorious moments in the unit's
quickstart/
life are properly highlighted.
LOL
https:/ /codereview. appspot. com/15020043/