Code review comment for lp:~frankban/juju-quickstart/quickstart-watch

Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+191801_code.launchpad.net,

Message:
Please take a look.

Description:
Wait for the GUI to be ready and started.

Watch unit changes, open the browser at the
end of the process.

Tests: run `make check`.

QA assuming you have an ec2 Juju env named 'ec2':
- run `.venv/bin/python juju-quickstart -e ec2`.
The environment is bootstrapped, the GUI deployed,
relevant events on the GUI unit notified.
Your default browser shows the GUI when done.

https://code.launchpad.net/~frankban/juju-quickstart/quickstart-watch/+merge/191801

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/15020043/

Affected files (+296, -3 lines):
   A [revision details]
   M quickstart/__init__.py
   M quickstart/app.py
   M quickstart/manage.py
   M quickstart/tests/test_app.py
   M quickstart/tests/test_utils.py
   M quickstart/utils.py

« Back to merge proposal