Code review comment for lp:~frankban/juju-quickstart/prepare-new-release

Revision history for this message
Richard Harding (rharding) wrote :

LGTM with the one note on potential room for a docs update.

Will QA.

https://codereview.appspot.com/65970043/diff/1/quickstart/manage.py
File quickstart/manage.py (right):

https://codereview.appspot.com/65970043/diff/1/quickstart/manage.py#newcode392
quickstart/manage.py:392: requires_sudo =
app.bootstrap_requires_sudo(is_local)
yay for functions that can be tested in isolation.

https://codereview.appspot.com/65970043/diff/1/quickstart/settings.py
File quickstart/settings.py (right):

https://codereview.appspot.com/65970043/diff/1/quickstart/settings.py#newcode35
quickstart/settings.py:35: JUJU_DEFAULT_SERIES = ('precise', 'quantal',
'raring', 'saucy', 'trusty')
good call, are these tweaks needed to keep it up to date noted? Maybe a
releases section in the hacking doc can note to check the latest charm
version and such?

https://codereview.appspot.com/65970043/

« Back to merge proposal