Merge lp:~frankban/juju-quickstart/prepare-for-pypi into lp:juju-quickstart

Proposed by Francesco Banconi
Status: Merged
Merged at revision: 49
Proposed branch: lp:~frankban/juju-quickstart/prepare-for-pypi
Merge into: lp:juju-quickstart
Diff against target: 81 lines (+33/-8)
3 files modified
Makefile (+5/-1)
README.rst (+27/-6)
setup.py (+1/-1)
To merge this branch: bzr merge lp:~frankban/juju-quickstart/prepare-for-pypi
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+203770@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Francesco Banconi (frankban) wrote :
Download full text (3.9 KiB)

Reviewers: mp+203770_code.launchpad.net,

Message:
Please take a look.

Description:
Update for PyPI release.

https://code.launchpad.net/~frankban/juju-quickstart/prepare-for-pypi/+merge/203770

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/51790045/

Affected files (+35, -8 lines):
   M Makefile
   M README.rst
   A [revision details]
   M setup.py

Index: Makefile
=== modified file 'Makefile'
--- Makefile 2013-11-14 12:20:44 +0000
+++ Makefile 2014-01-29 15:25:06 +0000
@@ -55,6 +55,7 @@
   @echo ' Juju environment by setting the JUJU_ENV environment variable,'
   @echo ' e.g.: "make run JUJU_ENV=ec2".'
   @echo 'make clean - Get rid of bytecode files, build and dist dirs, venv.'
+ @echo 'make release - Register and upload a release on PyPI.'

  install:
   $(PYTHON) setup.py install
@@ -63,6 +64,9 @@
  lint: setup
   @$(VENV)/bin/flake8 --show-source --exclude=$(VENV) ./quickstart

+release: check
+ $(PYTHON) setup.py register sdist upload
+
  run: setup
   $(VENV)/bin/python ./juju-quickstart --debug

@@ -77,4 +81,4 @@
       --with-coverage --cover-package=quickstart quickstart
   @rm .coverage

-.PHONY: all clean check help install lint run setup source sysdeps test
+.PHONY: all clean check help install lint release run setup source sysdeps
test

Index: README.rst
=== modified file 'README.rst'
--- README.rst 2013-11-06 15:21:19 +0000
+++ README.rst 2014-01-29 15:25:06 +0000
@@ -1,9 +1,30 @@
  Juju Quickstart
  ===============

-Juju Quickstart is a Juju plugin which allows for easily setting up a Juju
-environment in very few steps. The environment is bootstrapped and set up
so
-that it can be managed using a Web interface (the Juju GUI).
-
-Bundle deployments are also supported, and allow for setting up a complete
-topology of services in one simple command.
+Juju Quickstart is an opinionated command-line tool that quickly starts
Juju
+and the GUI, whether you've never installed Juju or you have an existing
Juju
+environment running.
+
+Features include the following:
+
+* New users are guided, as needed, to install Juju, set up SSH keys, and
+ configure it for first use.
+* Juju environments can be created and managed from a command line
interactive
+ session.
+* The Juju GUI is automatically installed, adding no additional machines
+ (installing on an existing state server when possible).
+* Bundles can be deployed, from local files, HTTP(S) URLs or the charm
store,
+ so that a complete topology of services can be set up in one simple
command.
+* Quickstart ends by opening the browser and automatically logging the user
+ into the GUI, to observe and manage the environment visually.
+* Users with a running Juju environment can run the quickstart command
again to
+ simply re-open the GUI without having to find the proper URL and
password.
+
+To install and start Juju Quickstart, run the following::
+
+ juju-quickstart [-i]
+
+Run ``juju-quickstart -h`` for a list of all the available options.
+
+Once Juju has been installed, the command can also be run as a juju plugin,
+without the hyphen (``juju quickstart``).

Index: [revision details]
=== ad...

Read more...

Revision history for this message
Gary Poster (gary) wrote :
Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Update for PyPI release.

R=gary.poster
CC=
https://codereview.appspot.com/51790045

https://codereview.appspot.com/51790045/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile'
--- Makefile 2013-11-14 12:20:44 +0000
+++ Makefile 2014-01-29 15:26:13 +0000
@@ -55,6 +55,7 @@
55 @echo ' Juju environment by setting the JUJU_ENV environment variable,'55 @echo ' Juju environment by setting the JUJU_ENV environment variable,'
56 @echo ' e.g.: "make run JUJU_ENV=ec2".'56 @echo ' e.g.: "make run JUJU_ENV=ec2".'
57 @echo 'make clean - Get rid of bytecode files, build and dist dirs, venv.'57 @echo 'make clean - Get rid of bytecode files, build and dist dirs, venv.'
58 @echo 'make release - Register and upload a release on PyPI.'
5859
59install:60install:
60 $(PYTHON) setup.py install61 $(PYTHON) setup.py install
@@ -63,6 +64,9 @@
63lint: setup64lint: setup
64 @$(VENV)/bin/flake8 --show-source --exclude=$(VENV) ./quickstart65 @$(VENV)/bin/flake8 --show-source --exclude=$(VENV) ./quickstart
6566
67release: check
68 $(PYTHON) setup.py register sdist upload
69
66run: setup70run: setup
67 $(VENV)/bin/python ./juju-quickstart --debug71 $(VENV)/bin/python ./juju-quickstart --debug
6872
@@ -77,4 +81,4 @@
77 --with-coverage --cover-package=quickstart quickstart81 --with-coverage --cover-package=quickstart quickstart
78 @rm .coverage82 @rm .coverage
7983
80.PHONY: all clean check help install lint run setup source sysdeps test84.PHONY: all clean check help install lint release run setup source sysdeps test
8185
=== modified file 'README.rst'
--- README.rst 2013-11-06 15:21:19 +0000
+++ README.rst 2014-01-29 15:26:13 +0000
@@ -1,9 +1,30 @@
1Juju Quickstart1Juju Quickstart
2===============2===============
33
4Juju Quickstart is a Juju plugin which allows for easily setting up a Juju4Juju Quickstart is an opinionated command-line tool that quickly starts Juju
5environment in very few steps. The environment is bootstrapped and set up so5and the GUI, whether you've never installed Juju or you have an existing Juju
6that it can be managed using a Web interface (the Juju GUI).6environment running.
77
8Bundle deployments are also supported, and allow for setting up a complete8Features include the following:
9topology of services in one simple command.9
10* New users are guided, as needed, to install Juju, set up SSH keys, and
11 configure it for first use.
12* Juju environments can be created and managed from a command line interactive
13 session.
14* The Juju GUI is automatically installed, adding no additional machines
15 (installing on an existing state server when possible).
16* Bundles can be deployed, from local files, HTTP(S) URLs or the charm store,
17 so that a complete topology of services can be set up in one simple command.
18* Quickstart ends by opening the browser and automatically logging the user
19 into the GUI, to observe and manage the environment visually.
20* Users with a running Juju environment can run the quickstart command again to
21 simply re-open the GUI without having to find the proper URL and password.
22
23To install and start Juju Quickstart, run the following::
24
25 juju-quickstart [-i]
26
27Run ``juju-quickstart -h`` for a list of all the available options.
28
29Once Juju has been installed, the command can also be run as a juju plugin,
30without the hyphen (``juju quickstart``).
1031
=== modified file 'setup.py'
--- setup.py 2013-11-14 10:37:29 +0000
+++ setup.py 2014-01-29 15:26:13 +0000
@@ -64,7 +64,7 @@
64 install_requires=install_requires,64 install_requires=install_requires,
65 zip_safe=False,65 zip_safe=False,
66 classifiers=[66 classifiers=[
67 'Development Status :: 3 - Alpha',67 'Development Status :: 5 - Production/Stable',
68 'Environment :: Web Environment',68 'Environment :: Web Environment',
69 'Intended Audience :: System Administrators',69 'Intended Audience :: System Administrators',
70 'License :: OSI Approved :: GNU Affero General Public License v3',70 'License :: OSI Approved :: GNU Affero General Public License v3',

Subscribers

People subscribed via source and target branches