Code review comment for lp:~frankban/juju-quickstart/ppa-flag

Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Support the --ppa flag for distro packaging.

Add a packaging module suitable for being
easily modified when packaging quickstart for
distro repositories.

The new --ppa flag can be used to switch to ppa
when quickstart is installed from the default
repositories.

Tests: `make check`.

QA: there is no easy way to QA this.
It would require removing juju packages,
running quickstart with and without
the --distro-only and --ppa flags,
switching packaging.py to "distro"
and trying again.
I'll do that anyway as part of the next
release QA, so feel free to avoid QAing now.

R=bac
CC=
https://codereview.appspot.com/84520047

https://codereview.appspot.com/84520047/diff/1/quickstart/manage.py
File quickstart/manage.py (right):

https://codereview.appspot.com/84520047/diff/1/quickstart/manage.py#newcode76
quickstart/manage.py:76: ppa_help += '\n(enabled by default, use
--distro-only to disable)'
On 2014/04/07 14:46:33, bac wrote:
> DRY: pull out this message into a template that gets populated
appropriately?
> +0

Done.

https://codereview.appspot.com/84520047/

« Back to merge proposal