Code review comment for lp:~frankban/juju-quickstart/optional-fields

Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+257913_code.launchpad.net,

Message:
Please take a look.

Description:
Update provider fields.

Update the list of fields that quickstart
expects for each provider type. Also make
some OpenStack fields optional
(use-floating-ip, tenant-name and region).

Update the links to the provider documentation
(use jujucharms.com).

Update the jujubundlelib dependency to use the
latest one.

Tests: `make check`.

QA:
- check that the environment editing in the
interactive session looks good
(especially the openstack/azure environments
creation).
- use quickstart as usual
(`devenv/bin/juju-quickstart`), to start
(for instance) an ec2 or an azure environment.

https://code.launchpad.net/~frankban/juju-quickstart/optional-fields/+merge/257913

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/234150043/

Affected files (+75, -35 lines):
   A [revision details]
   M quickstart/cli/forms.py
   M quickstart/models/envs.py
   M quickstart/tests/models/test_envs.py
   M tox.ini

« Back to merge proposal