Code review comment for lp:~frankban/juju-quickstart/open-urls

Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Deploy a bundle from a HTTP(S) url.

The bundle argument can be a file path or
a http/https URL pointing to a bundle YAML.

Also get the URL of the last Juju GUI charm
revision from charmworld (API 2 for now).

Tests: `make check`.

QA:
I copied a bundle YAML over here:
http://dpaste.com/1435065/plain/
You should be able to deploy that bundle
by running the following (after juju switching to ec2 or similar):
`.venv/bin/python juju-quickstart http://dpaste.com/1435065/plain/`
Remember to destroy your ec2 environment...

R=gary.poster
CC=
https://codereview.appspot.com/19870043

https://codereview.appspot.com/19870043/diff/1/quickstart/utils.py
File quickstart/utils.py (right):

https://codereview.appspot.com/19870043/diff/1/quickstart/utils.py#newcode35
quickstart/utils.py:35: # Switch to charmworld API 3 when the 500 error
is fixed.
On 2013/10/30 20:58:55, gary.poster wrote:
> We had a fix and a deployment, and
> http://manage.jujucharms.com/api/3/charm/precise/juju-gui works now
(yay!)

Cool! Done.

https://codereview.appspot.com/19870043/

« Back to merge proposal