Code LGTM with trivial update. Trying QA now.
https://codereview.appspot.com/19870043/diff/1/quickstart/app.py File quickstart/app.py (right):
https://codereview.appspot.com/19870043/diff/1/quickstart/app.py#newcode126 quickstart/app.py:126: logging.warn(msg.format(err)) nice.
https://codereview.appspot.com/19870043/diff/1/quickstart/tests/test_app.py File quickstart/tests/test_app.py (right):
https://codereview.appspot.com/19870043/diff/1/quickstart/tests/test_app.py#newcode263 quickstart/tests/test_app.py:263: with self.patch_get_charm_url(side_effect=IOError('boo!')): You scared me.
https://codereview.appspot.com/19870043/diff/1/quickstart/utils.py File quickstart/utils.py (right):
https://codereview.appspot.com/19870043/diff/1/quickstart/utils.py#newcode35 quickstart/utils.py:35: # Switch to charmworld API 3 when the 500 error is fixed. We had a fix and a deployment, and http://manage.jujucharms.com/api/3/charm/precise/juju-gui works now (yay!)
https://codereview.appspot.com/19870043/
« Back to merge proposal
Code LGTM with trivial update. Trying QA now.
https:/ /codereview. appspot. com/19870043/ diff/1/ quickstart/ app.py
File quickstart/app.py (right):
https:/ /codereview. appspot. com/19870043/ diff/1/ quickstart/ app.py# newcode126 app.py: 126: logging. warn(msg. format( err))
quickstart/
nice.
https:/ /codereview. appspot. com/19870043/ diff/1/ quickstart/ tests/test_ app.py tests/test_ app.py (right):
File quickstart/
https:/ /codereview. appspot. com/19870043/ diff/1/ quickstart/ tests/test_ app.py# newcode263 tests/test_ app.py: 263: with get_charm_ url(side_ effect= IOError( 'boo!') ):
quickstart/
self.patch_
You scared me.
https:/ /codereview. appspot. com/19870043/ diff/1/ quickstart/ utils.py
File quickstart/utils.py (right):
https:/ /codereview. appspot. com/19870043/ diff/1/ quickstart/ utils.py# newcode35 utils.py: 35: # Switch to charmworld API 3 when the 500 error manage. jujucharms. com/api/ 3/charm/ precise/ juju-gui works now
quickstart/
is fixed.
We had a fix and a deployment, and
http://
(yay!)
https:/ /codereview. appspot. com/19870043/