https://codereview.appspot.com/84630043/diff/20001/quickstart/app.py#newcode420
quickstart/app.py:420: collected_machine_changes = []
Can we use something like a hash keyed by machine_id (or something else
since it might not have an id per below) and then just update the
changes/state as it comes in to not need to sort/reverse/etc everything.
Just always keep the latest info for the key? I'm guessing not, but
curious as to the process.
LGTM, couple of questions/comments. I think I follow the first one now.
If only you could order files in review to line up better.
https:/ /codereview. appspot. com/84630043/ diff/20001/ quickstart/ app.py
File quickstart/app.py (right):
https:/ /codereview. appspot. com/84630043/ diff/20001/ quickstart/ app.py# newcode420 app.py: 420: collected_ machine_ changes = []
quickstart/
Can we use something like a hash keyed by machine_id (or something else
since it might not have an id per below) and then just update the
changes/state as it comes in to not need to sort/reverse/etc everything.
Just always keep the latest info for the key? I'm guessing not, but
curious as to the process.
https:/ /codereview. appspot. com/84630043/ diff/20001/ quickstart/ tests/test_ watchers. py tests/test_ watchers. py (right):
File quickstart/
https:/ /codereview. appspot. com/84630043/ diff/20001/ quickstart/ tests/test_ watchers. py#newcode52 tests/test_ watchers. py:52: lxc_addresses = [
quickstart/
these can be kvm as well correct? Should these be tested as part of this
or is there no difference other than the three chars?
https:/ /codereview. appspot. com/84630043/