Code review comment for lp:~frankban/juju-quickstart/new-machine-info

Revision history for this message
Brad Crittenden (bac) wrote :

LGTM. Will QA now.

https://codereview.appspot.com/84630043/diff/1/quickstart/models/envs.py
File quickstart/models/envs.py (right):

https://codereview.appspot.com/84630043/diff/1/quickstart/models/envs.py#newcode444
quickstart/models/envs.py:444: 'The ec2 provider enables you to run Juju
on the EC2 cloud. '
This change looks familiar...

https://codereview.appspot.com/84630043/diff/1/quickstart/tests/test_watchers.py
File quickstart/tests/test_watchers.py (right):

https://codereview.appspot.com/84630043/diff/1/quickstart/tests/test_watchers.py#newcode85
quickstart/tests/test_watchers.py:85: # None is returned if an LXC
public address is not available.
Two spaces: LXC public

(I know you hate those!)

https://codereview.appspot.com/84630043/diff/1/quickstart/tests/test_watchers.py#newcode114
quickstart/tests/test_watchers.py:114: # The public address of an LXC
instance is proprely returned.
typo: properly

https://codereview.appspot.com/84630043/

« Back to merge proposal