https://codereview.appspot.com/199490043/diff/1/quickstart/models/jenv.py#newcode134
quickstart/models/jenv.py:134: data =
serializers.yaml_load_from_path(jenv_path)
I believe there are other places in the code which require information
from the jenv file so I figured that this would already be abstracted
out into a utility method already so you could just fetch the value.
LGTM with some possible cleanups.
QA OK!
https:/ /codereview. appspot. com/199490043/ diff/1/ quickstart/ app.py
File quickstart/app.py (right):
https:/ /codereview. appspot. com/199490043/ diff/1/ quickstart/ app.py# newcode283 app.py: 283: def get_env_ uuid_or_ none(env_ name):
quickstart/
On 2015/02/10 10:47:32, martin.hilton wrote:
> Is it really necessary to have or_none in the name of this function?
+1
https:/ /codereview. appspot. com/199490043/ diff/1/ quickstart/ models/ jenv.py models/ jenv.py (right):
File quickstart/
https:/ /codereview. appspot. com/199490043/ diff/1/ quickstart/ models/ jenv.py# newcode134 models/ jenv.py: 134: data = yaml_load_ from_path( jenv_path)
quickstart/
serializers.
I believe there are other places in the code which require information
from the jenv file so I figured that this would already be abstracted
out into a utility method already so you could just fetch the value.
https:/ /codereview. appspot. com/199490043/