https://codereview.appspot.com/52080044/diff/1/quickstart/models/envs.py#newcode529
quickstart/models/envs.py:529: fields.ChoiceField(
should this be a suggestion field to help users move along faster? Just
suggest a sensible default like US East which I think even things like
the AMZ web ui does? It's a suggestion field in the open stack example
above.
https://codereview.appspot.com/52080044/diff/1/quickstart/tests/cli/test_forms.py#newcode174
quickstart/tests/cli/test_forms.py:174: class
TestCreateStringWidget(ChoicesTestsMixin, unittest.TestCase):
I think that the suggestion field is its own new class and should have
its own tests vs getting shoed into the String widget tests. This seems
like a path down like the one in the charm where the one suite of tests
contained others that weren't directly related.
Code looks good, a couple of comments.
Starting QA.
https:/ /codereview. appspot. com/52080044/ diff/1/ quickstart/ __init_ _.py __init_ _.py (right):
File quickstart/
https:/ /codereview. appspot. com/52080044/ diff/1/ quickstart/ __init_ _.py#newcode25 __init_ _.py:25: VERSION = (1, 0, 0)
quickstart/
wahoo!
https:/ /codereview. appspot. com/52080044/ diff/1/ quickstart/ models/ envs.py models/ envs.py (right):
File quickstart/
https:/ /codereview. appspot. com/52080044/ diff/1/ quickstart/ models/ envs.py# newcode529 models/ envs.py: 529: fields.ChoiceField(
quickstart/
should this be a suggestion field to help users move along faster? Just
suggest a sensible default like US East which I think even things like
the AMZ web ui does? It's a suggestion field in the open stack example
above.
https:/ /codereview. appspot. com/52080044/ diff/1/ quickstart/ tests/cli/ test_forms. py tests/cli/ test_forms. py (right):
File quickstart/
https:/ /codereview. appspot. com/52080044/ diff/1/ quickstart/ tests/cli/ test_forms. py#newcode174 tests/cli/ test_forms. py:174: class gWidget( ChoicesTestsMix in, unittest.TestCase):
quickstart/
TestCreateStrin
I think that the suggestion field is its own new class and should have
its own tests vs getting shoed into the String widget tests. This seems
like a path down like the one in the charm where the one suite of tests
contained others that weren't directly related.
https:/ /codereview. appspot. com/52080044/