Merge lp:~frankban/juju-quickstart/lbox-requiring-sudo into lp:juju-quickstart

[Francesco Banconi]

Avoid requiring sudo privileges on lbox submit.

https://codereview.appspot.com/199470043/

[Francesco Banconi (frankban)]

Reviewers: mp+249047_code.launchpad.net,

Message:
Please take a look.

Description:
Avoid requiring sudo privileges on lbox submit.

https://code.launchpad.net/~frankban/juju-quickstart/lbox-requiring-sudo/+merge/249047

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/199470043/

Affected files (+5, -0 lines):
   M .lbox.check
   A [revision details]

Index: .lbox.check
=== modified file '.lbox.check'
--- .lbox.check 2013-10-14 11:43:06 +0000
+++ .lbox.check 2015-02-09 10:19:10 +0000
@@ -1,3 +1,6 @@
  #!/bin/sh

+# Avoid requiring sudo privileges to install system dependencies.
+touch .sysdeps-installed
+# Run all the unit tests.
  make check

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision:
<email address hidden>
+New revision:
<email address hidden>

[Francesco Banconi (frankban)]

Self review: trivial.

https://codereview.appspot.com/199470043/

[lp:~frankban/juju-quickstart/lbox-requiring-sudo]

120. By Francesco Banconi on 2015-02-09

Ignore lambda pep8 and fix lint errors.

[Francesco Banconi (frankban)]

Please take a look.

https://codereview.appspot.com/199470043/

[Francesco Banconi (frankban)]

*** Submitted:

Avoid requiring sudo privileges on lbox submit.

R=
CC=
https://codereview.appspot.com/199470043

https://codereview.appspot.com/199470043/

=== modified file '.lbox.check'
--- .lbox.check	2013-10-14 11:43:06 +0000
+++ .lbox.check	2015-02-09 10:38:39 +0000
@@ -1,3 +1,6 @@
 #!/bin/sh
 
+# Avoid requiring sudo privileges to install system dependencies.
+touch .sysdeps-installed
+# Run all the unit tests.
 make check

=== modified file 'Makefile'
--- Makefile	2015-01-30 16:42:29 +0000
+++ Makefile	2015-02-09 10:38:39 +0000
@@ -104,7 +104,7 @@
 
 .PHONY: lint
 lint: setup
-	@$(DEVENV)/bin/flake8 --show-source quickstart
+	@$(DEVENV)/bin/flake8 --ignore E731 --show-source quickstart
 
 .PHONY: release
 release: check

=== modified file 'quickstart/app.py'
--- quickstart/app.py	2015-01-12 15:00:52 +0000
+++ quickstart/app.py	2015-02-09 10:38:39 +0000
@@ -257,7 +257,7 @@
     Raise a ProgramExit if the agent is not ready after ten minutes or if the
     agent is in an error state.
     """
-    timeout = time.time() + (60*10)
+    timeout = time.time() + (60 * 10)
     while time.time() < timeout:
         retcode, output, error = utils.call(
             juju_command, 'status', '-e', env_name, '--format', 'yaml')

=== modified file 'quickstart/tests/models/test_envs.py'
--- quickstart/tests/models/test_envs.py	2014-11-12 16:09:30 +0000
+++ quickstart/tests/models/test_envs.py	2015-02-09 10:38:39 +0000
@@ -712,7 +712,7 @@
         env_metadata = self.env_type_db['ec2']
         expected = [
             'type', 'name', 'access-key', 'secret-key', 'region',
-            'admin-secret', 'default-series', 'control-bucket',  'is-default']
+            'admin-secret', 'default-series', 'control-bucket', 'is-default']
         expected_required = [
             'type', 'name', 'access-key', 'secret-key',
             'is-default']

=== modified file 'tox.ini'
--- tox.ini	2015-01-30 16:26:02 +0000
+++ tox.ini	2015-02-09 10:38:39 +0000
@@ -108,4 +108,4 @@
 [testenv:lint]
 usedevelop = True
 deps = flake8==2.3.0
-commands = flake8 --show-source quickstart
+commands = flake8 --ignore E731 --show-source quickstart