juju-quickstart

Code review comment for lp:~frankban/juju-quickstart/joyent

  1. joyent
  2. Merge into trunk
Revision history for this message
Brad Crittenden (bac) wrote :

Code LGTM. On to QA.

https://codereview.appspot.com/83880044/diff/1/quickstart/tests/models/test_fields.py
File quickstart/tests/models/test_fields.py (right):

https://codereview.appspot.com/83880044/diff/1/quickstart/tests/models/test_fields.py#newcode468
quickstart/tests/models/test_fields.py:468:
field.validate(unicode(__file__))
Nice use of __file__. Nicer then creating a temp file and destroying
it.

https://codereview.appspot.com/83880044/

« Back to merge proposal