> I was surprised to see the username printed as 'user-bac' (because I
hadn't
> noticed that part of the code).
> Why do we have the user- prefix? Is that a juju-gui thing?
> I don't think we should make that user visible, i.e. don't print
'user-' when
> showing the credentials being used. The prefix does not appear in the
.jenv file
> or 'juju user list'.
Hi Brad,
the use prefix is required when loggin in to the Juju API. But I agree
with you:
hiding it in the UX could be a good idea, especially because I checked
with
the GUI trunk and we already do that in the login form.
I'll merge this and propose a follow up branch to hide the prefix.
Thank you for the QA and thank you all for the reviews!
On 2014/12/15 19:54:50, bac wrote:
> QA - OK
> I was surprised to see the username printed as 'user-bac' (because I
hadn't
> noticed that part of the code).
> Why do we have the user- prefix? Is that a juju-gui thing?
> I don't think we should make that user visible, i.e. don't print
'user-' when
> showing the credentials being used. The prefix does not appear in the
.jenv file
> or 'juju user list'.
Hi Brad,
the use prefix is required when loggin in to the Juju API. But I agree
with you:
hiding it in the UX could be a good idea, especially because I checked
with
the GUI trunk and we already do that in the login form.
I'll merge this and propose a follow up branch to hide the prefix.
Thank you for the QA and thank you all for the reviews!
https:/ /codereview. appspot. com/190060043/