Code review comment for lp:~frankban/juju-quickstart/interactive-jenvs

Revision history for this message
Francesco Banconi (frankban) wrote :

Thanks for the reviews!

https://codereview.appspot.com/188330043/diff/1/quickstart/tests/helpers.py
File quickstart/tests/helpers.py (right):

https://codereview.appspot.com/188330043/diff/1/quickstart/tests/helpers.py#newcode266
quickstart/tests/helpers.py:266: 'type': '__unknown__',
On 2014/12/17 16:13:07, j.c.sackett wrote:
> This isn't from your branch, but why are we listing ec2 as an
"unknown"?

All the jenv files created by "juju user add" don't include the provider
type. So the type can be unknown even if the name suggests a specific
provider.

https://codereview.appspot.com/188330043/

« Back to merge proposal