juju-quickstart

Code review comment for lp:~frankban/juju-quickstart/interactive-jenvs

  1. interactive-jenvs
  2. Merge into trunk
Revision history for this message
j.c.sackett (jcsackett) wrote :

LGTM, Franceso. Just one question, and it's not directly related to your
branch.

https://codereview.appspot.com/188330043/diff/1/quickstart/tests/helpers.py
File quickstart/tests/helpers.py (right):

https://codereview.appspot.com/188330043/diff/1/quickstart/tests/helpers.py#newcode266
quickstart/tests/helpers.py:266: 'type': '__unknown__',
This isn't from your branch, but why are we listing ec2 as an "unknown"?

https://codereview.appspot.com/188330043/

« Back to merge proposal