Code review comment for lp:~frankban/juju-quickstart/improve-venv

Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Update the quickstart test venv set up process.

Remove the activate file if the requirements
installation process fails.

Also updated the default GUI charm URL, and
the documentation.

R=gary.poster
CC=
https://codereview.appspot.com/26540043

https://codereview.appspot.com/26540043/diff/1/HACKING.rst
File HACKING.rst (right):

https://codereview.appspot.com/26540043/diff/1/HACKING.rst#newcode97
HACKING.rst:97: Also ensure, before updating the application
dependencies, that those packages
On 2013/11/14 12:04:01, gary.poster wrote:
> I suggest that you make this a second paragraph, since it is a
separate topic.

Done.

https://codereview.appspot.com/26540043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/26540043/diff/1/Makefile#newcode27
Makefile:27: (rm -f $(VENV_ACTIVATE); exit 1)
On 2013/11/14 12:04:01, gary.poster wrote:
> same comment as with gui charm: instead of rm'ing, let's touch
> test-requirements.pip.

Done.

https://codereview.appspot.com/26540043/

« Back to merge proposal