Code review comment for lp:~frankban/juju-quickstart/improve-venv

Revision history for this message
Gary Poster (gary) wrote :

Nice. LGTM with trivial comments.

https://codereview.appspot.com/26540043/diff/1/HACKING.rst
File HACKING.rst (right):

https://codereview.appspot.com/26540043/diff/1/HACKING.rst#newcode97
HACKING.rst:97: Also ensure, before updating the application
dependencies, that those packages
I suggest that you make this a second paragraph, since it is a separate
topic.

https://codereview.appspot.com/26540043/diff/1/MANIFEST.in
File MANIFEST.in (right):

https://codereview.appspot.com/26540043/diff/1/MANIFEST.in#newcode23
MANIFEST.in:23: # distribution and therefore the Debian package builds.
Do not do that.
Thank you for this comment!

https://codereview.appspot.com/26540043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/26540043/diff/1/Makefile#newcode27
Makefile:27: (rm -f $(VENV_ACTIVATE); exit 1)
same comment as with gui charm: instead of rm'ing, let's touch
test-requirements.pip.

https://codereview.appspot.com/26540043/

« Back to merge proposal