Code review comment for lp:~frankban/juju-quickstart/idempotent-feature

Revision history for this message
Richard Harding (rharding) wrote :

LGTM and qa-ok.

I'm with Gary on the is_bootstrapped being a bit confusing sometimes in
the inner workings.

I also get a bit confused with the 'charm_url' as I forget that in this
context that's ALWAYS the Gui charm. As features grow and things like
deploying bundles come into the picture, I wonder if a
s/charm_url/gui_charm_url might be in order.

https://codereview.appspot.com/28250044/diff/1/quickstart/app.py
File quickstart/app.py (right):

https://codereview.appspot.com/28250044/diff/1/quickstart/app.py#newcode74
quickstart/app.py:74: # jens files seems to be an internal juju-core
detail. Definitely we
jenv

https://codereview.appspot.com/28250044/

« Back to merge proposal