Merge lp:~frankban/juju-quickstart/hp-fixes into lp:juju-quickstart

Proposed by Francesco Banconi
Status: Merged
Merged at revision: 84
Proposed branch: lp:~frankban/juju-quickstart/hp-fixes
Merge into: lp:juju-quickstart
Diff against target: 79 lines (+15/-11)
2 files modified
quickstart/__init__.py (+1/-1)
quickstart/models/envs.py (+14/-10)
To merge this branch: bzr merge lp:~frankban/juju-quickstart/hp-fixes
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+223445@code.launchpad.net

Description of the change

Align to the latest HP Cloud config options.

https://codereview.appspot.com/105920046/

To post a comment you must log in.
Revision history for this message
Francesco Banconi (frankban) wrote :
Download full text (4.9 KiB)

Reviewers: mp+223445_code.launchpad.net,

Message:
Please take a look.

Description:
Align to the latest HP Cloud config options.

https://code.launchpad.net/~frankban/juju-quickstart/hp-fixes/+merge/223445

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/105920046/

Affected files (+17, -11 lines):
   A [revision details]
   M quickstart/__init__.py
   M quickstart/models/envs.py

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision:
<email address hidden>

Index: quickstart/__init__.py
=== modified file 'quickstart/__init__.py'
--- quickstart/__init__.py 2014-06-12 00:37:46 +0000
+++ quickstart/__init__.py 2014-06-17 16:07:50 +0000
@@ -45,7 +45,7 @@
  Once Juju has been installed, the command can also be run as a juju plugin,
  without the hyphen ("juju quickstart").
  """
-VERSION = (1, 3, 5)
+VERSION = (1, 4, 0)

  def get_version():

Index: quickstart/models/envs.py
=== modified file 'quickstart/models/envs.py'
--- quickstart/models/envs.py 2014-06-16 10:00:00 +0000
+++ quickstart/models/envs.py 2014-06-17 16:07:50 +0000
@@ -419,8 +419,7 @@
          'eu-west-1', 'sa-east-1',
          'us-east-1', 'us-west-1', 'us-west-2',
      )
- hp_regions = (
- 'az-1.region-a.geo-1', 'az-2.region-a.geo-1', 'az-3.region-a.geo-1')
+ hp_regions = ('region-a.geo-1', 'region-b.geo-1')
      azure_locations = (
          'East US', 'West US', 'West Europe', 'North Europe',
          'Southeast Asia', 'East Asia')
@@ -512,7 +511,8 @@
                  help='Specifies whether the use of a floating IP address
is '
                       'required to give the nodes a public IP address. '
                       'Some installations assign public IP addresses by '
- 'default without requiring a floating IP address.'),
+ 'default without requiring a floating IP address. '
+ 'For HP Public Cloud, floating IP must be
activated.'),
              fields.AutoGeneratedStringField(
                  'control-bucket', label='control bucket', required=False,
                  help='the globally unique swift bucket name'),
@@ -526,7 +526,7 @@
                  'tenant-name', label='tenant name', required=True,
                  help='The OpenStack tenant name. For HP Public Cloud, this
is '
                       'listed as the project name on the '
- 'https://account.hpcloud.com/projects page.'),
+ 'https://horizon.hpcloud.com/landing/ page.'),
              fields.SuggestionsStringField(
                  'region', label='region', required=True,
                  help='The OpenStack region to use. '
@@ -538,15 +538,17 @@
                  help='The way Juju authenticates to OpenStack. The
userpass '
                       'authentication requires you to fill in your user
name '
                       'and password. The keypair mode requires access ke...

Read more...

Revision history for this message
Brad Crittenden (bac) wrote :

LGTM. No QA.

https://codereview.appspot.com/105920046/diff/1/quickstart/models/envs.py
File quickstart/models/envs.py (left):

https://codereview.appspot.com/105920046/diff/1/quickstart/models/envs.py#oldcode542
quickstart/models/envs.py:542: 'these information can be retrieved on
the '
wow, glad that's gone!

https://codereview.appspot.com/105920046/

Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Align to the latest HP Cloud config options.

R=bac
CC=
https://codereview.appspot.com/105920046

https://codereview.appspot.com/105920046/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'quickstart/__init__.py'
--- quickstart/__init__.py 2014-06-12 00:37:46 +0000
+++ quickstart/__init__.py 2014-06-17 16:51:53 +0000
@@ -45,7 +45,7 @@
45Once Juju has been installed, the command can also be run as a juju plugin,45Once Juju has been installed, the command can also be run as a juju plugin,
46without the hyphen ("juju quickstart").46without the hyphen ("juju quickstart").
47"""47"""
48VERSION = (1, 3, 5)48VERSION = (1, 4, 0)
4949
5050
51def get_version():51def get_version():
5252
=== modified file 'quickstart/models/envs.py'
--- quickstart/models/envs.py 2014-06-16 10:00:00 +0000
+++ quickstart/models/envs.py 2014-06-17 16:51:53 +0000
@@ -419,8 +419,7 @@
419 'eu-west-1', 'sa-east-1',419 'eu-west-1', 'sa-east-1',
420 'us-east-1', 'us-west-1', 'us-west-2',420 'us-east-1', 'us-west-1', 'us-west-2',
421 )421 )
422 hp_regions = (422 hp_regions = ('region-a.geo-1', 'region-b.geo-1')
423 'az-1.region-a.geo-1', 'az-2.region-a.geo-1', 'az-3.region-a.geo-1')
424 azure_locations = (423 azure_locations = (
425 'East US', 'West US', 'West Europe', 'North Europe',424 'East US', 'West US', 'West Europe', 'North Europe',
426 'Southeast Asia', 'East Asia')425 'Southeast Asia', 'East Asia')
@@ -512,7 +511,8 @@
512 help='Specifies whether the use of a floating IP address is '511 help='Specifies whether the use of a floating IP address is '
513 'required to give the nodes a public IP address. '512 'required to give the nodes a public IP address. '
514 'Some installations assign public IP addresses by '513 'Some installations assign public IP addresses by '
515 'default without requiring a floating IP address.'),514 'default without requiring a floating IP address. '
515 'For HP Public Cloud, floating IP must be activated.'),
516 fields.AutoGeneratedStringField(516 fields.AutoGeneratedStringField(
517 'control-bucket', label='control bucket', required=False,517 'control-bucket', label='control bucket', required=False,
518 help='the globally unique swift bucket name'),518 help='the globally unique swift bucket name'),
@@ -526,7 +526,7 @@
526 'tenant-name', label='tenant name', required=True,526 'tenant-name', label='tenant name', required=True,
527 help='The OpenStack tenant name. For HP Public Cloud, this is '527 help='The OpenStack tenant name. For HP Public Cloud, this is '
528 'listed as the project name on the '528 'listed as the project name on the '
529 'https://account.hpcloud.com/projects page.'),529 'https://horizon.hpcloud.com/landing/ page.'),
530 fields.SuggestionsStringField(530 fields.SuggestionsStringField(
531 'region', label='region', required=True,531 'region', label='region', required=True,
532 help='The OpenStack region to use. '532 help='The OpenStack region to use. '
@@ -538,15 +538,17 @@
538 help='The way Juju authenticates to OpenStack. The userpass '538 help='The way Juju authenticates to OpenStack. The userpass '
539 'authentication requires you to fill in your user name '539 'authentication requires you to fill in your user name '
540 'and password. The keypair mode requires access key and '540 'and password. The keypair mode requires access key and '
541 'secret key to be properly set up. For HP Public Cloud '541 'secret key to be properly set up. For HP Public Cloud, '
542 'these information can be retrieved on the '542 'select userpass mode and type your HP Cloud login '
543 'https://account.hpcloud.com/account/api_keys page.'),543 'user name and password below.'),
544 fields.StringField(544 fields.StringField(
545 'username', label='user name', required=False,545 'username', label='user name', required=False,
546 help='the user name to use for the userpass authentication'),546 help='the user name to use for the userpass authentication '
547 '(or the HP Cloud login user name)'),
547 fields.PasswordField(548 fields.PasswordField(
548 'password', label='password', required=False,549 'password', label='password', required=False,
549 help='the user name to use for the userpass authentication'),550 help='the user name to use for the userpass authentication '
551 '(or the HP Cloud login password)'),
550 fields.StringField(552 fields.StringField(
551 'access-key', label='access key', required=False,553 'access-key', label='access key', required=False,
552 help='the access key to use for the keypair authentication'),554 help='the access key to use for the keypair authentication'),
@@ -603,7 +605,9 @@
603 'The joyent provider enables you to run Juju on the Joyent cloud. '605 'The joyent provider enables you to run Juju on the Joyent cloud. '
604 'This process requires you to have a Joyent account. If you have '606 'This process requires you to have a Joyent account. If you have '
605 'not signed up for one yet, it can obtained at '607 'not signed up for one yet, it can obtained at '
606 'http://www.joyent.com/.'608 'http://www.joyent.com/. See '
609 'https://juju.ubuntu.com/docs/config-joyent.html for more details '
610 'on the joyent provider configuration.'
607 ),611 ),
608 'fields': (612 'fields': (
609 provider_field,613 provider_field,

Subscribers

People subscribed via source and target branches