Code review comment for lp:~frankban/juju-quickstart/handle-machine-errors

Revision history for this message
Brad Crittenden (bac) wrote :

Code LGTM. Have not yet done QA.

https://codereview.appspot.com/51350044/diff/1/quickstart/app.py
File quickstart/app.py (right):

https://codereview.appspot.com/51350044/diff/1/quickstart/app.py#newcode467
quickstart/app.py:467: # specific unit. For this reason, we exit the for
loop here.
You don't sound convinced. Any chance that assumption is wrong? The
penalty for looping over the rest non-matching items is trivial. But if
you're sure, maybe keep this logic but change the comment to be more
confident.

https://codereview.appspot.com/51350044/diff/1/quickstart/app.py#newcode481
quickstart/app.py:481: # We assume the mega-watcher contains a single
change for each
As above.

https://codereview.appspot.com/51350044/

« Back to merge proposal