Code review comment for lp:~frankban/juju-quickstart/fix-num-units

Revision history for this message
Martin Hilton (martin-hilton) wrote :

LGTM, but make sure that the default 0 is correct for all cases.

https://codereview.appspot.com/235490043/diff/1/quickstart/models/bundles.py
File quickstart/models/bundles.py (left):

https://codereview.appspot.com/235490043/diff/1/quickstart/models/bundles.py#oldcode116
quickstart/models/bundles.py:116: result[service_name] =
services[service_name]['num_units']
Is 0 always a good default? I thought for subordinates it should be 0
but for normal charms it should be 1.

https://codereview.appspot.com/235490043/

« Back to merge proposal