Code review comment for lp:~frankban/juju-quickstart/env-manage-selection-view

Revision history for this message
Richard Harding (rharding) wrote :

LGTM

QA Notes:

The * in front of each alternates colors. Two are red, which I at first
thought was a default indicator.

The default is easy to miss down the row. I'ts in the () with type so I
assumed it was part of that at first. A typical thing in cli is to
bracket defaults with a []. Maybe the default row could be

[*checkmark*] lxc (type: local)

http://www.fileformat.info/info/unicode/char/2713/index.htm

or something?

<3 the unicode toxic type.

https://codereview.appspot.com/43860044/

« Back to merge proposal