Code review comment for lp:~frankban/juju-quickstart/env-manage-remove-environment

Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+199698_code.launchpad.net,

Message:
Please take a look.

Description:
Implement the remove env functionality.

It is now possible to remove environments
using the interactive session.

A confirmation dialog prevents the user
to accidentally remove an environment.

Tests: `make check`.
QA: start the demo app
(`make` and `./cli-app-demo.py).
Remove environments at will: exiting
from the app you should see the
new environments YAML without the
environments you deleted.
Any UX suggestion welcome.
Thank you!

https://code.launchpad.net/~frankban/juju-quickstart/env-manage-remove-environment/+merge/199698

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/44310043/

Affected files (+306, -30 lines):
   A [revision details]
   M quickstart/cli/ui.py
   M quickstart/cli/views.py
   M quickstart/models/envs.py
   M quickstart/tests/cli/helpers.py
   M quickstart/tests/cli/test_ui.py
   M quickstart/tests/cli/test_views.py
   M quickstart/tests/models/test_envs.py

« Back to merge proposal